Fix to pre_commit: create report.html in directory that exists
Reported by Chris Parsons | April 18th, 2008 @ 12:36 AM | in No-Milestone-Assigned
Given a clean clone from 79123488 (on github), rake pre_commit fails.
The attached patch tweaks the change made in 4980e86 - it now seems to correctly find the path to output the report.html file to.
Comments and changes to this ticket
-
Chris Parsons April 18th, 2008 @ 12:37 AM
- → Title changed from “Fix to pre_commit” to “Fix to pre_commit: create report.html in directory that exists”
-
David Chelimsky April 18th, 2008 @ 02:52 AM
The path that's there is intended to push drop the report up in rspec-dev/doc/output. The path in this patch moves it to rspec-dev/example_rails_app/vendor/plugins/doc/output.
Both of these really present the same problem - if you just have the rspec directory and run pre_commit, it creates files outside it's own tree.
I'm inclined to put it in rspec/doc/output.
-
Chris Parsons April 18th, 2008 @ 11:32 AM
Agreed - perhaps something like the following patch (attached).
This should pass rake pre_commit from a clean repo, and seems more logical in its placement of files. Unfortunately pre_commit is failing due to drb timeouts this morning for some reason, so it's not as tested as I'd like.
-
Brian Takita May 22nd, 2008 @ 10:16 AM
Chris, you may need to update your /etc/hosts file to fix your drb timeouts.
Make sure localhost, 127.0.0.1, and 0.0.0.0 are in there.
See /usr/local/lib/ruby/1.8/drb/drb.rb:848
-
Chris Parsons May 22nd, 2008 @ 10:50 AM
Thanks Brian. Will give it a go.
On 22 May 2008, at 09:17, Lighthouse wrote:
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Behaviour Driven Development for Ruby.
