rspec

Comments and changes to this ticket

• 

  Robin Powell February 15th, 2008 @ 02:24 AM

  This patch, as well as the plain formatter, has a bug: it keeps saying "And" even across scenario boundaries, as long as the type doesn't change. Fixed patch attached; new ticket coming for the plain text formatter.

  -Robin

  • html_diffs.txt 1.8 KB
• 

  Pat Maddox May 24th, 2008 @ 06:51 PM

  This patch doesn't have unit tests. Could you please add some?

• 

  Joseph Wilk July 13th, 2008 @ 04:20 PM

  • → Title changed from “Patch to put nice "And"s in Story HTML output” to “"And"s in Story HTML/Plaintext output”
  • → Tag changed from “” to “featurerequest formatter patch story”

  I've picked up this patch. I changed the way the html/plain text outputs in previous commits so the attachments are somewhat out of date.

  I'll add a patch for html & plain text output to handle this asap.

• 

  Joseph Wilk July 14th, 2008 @ 12:08 PM

  • → Title changed from “"And"s in Story HTML/Plaintext output” to “"And"s in Story HTML output”

  Find the patch attached for 'ands' in html output.

  Plaintext is already working so nothing to do there :)

• 

  Joseph Wilk July 14th, 2008 @ 12:17 PM

  • no changes were found...

  • ands_in_story_html_output.patch 3.6 KB
• 

  David Chelimsky July 14th, 2008 @ 01:38 PM

  Hey Joseph - this patch looks good. Can I convince you to resubmit the patch using 'git-format-patch'? That way the commit comes from you instead of me :)

• 

  Joseph Wilk July 14th, 2008 @ 01:50 PM

  Sure, I'll re-submit in just a tick.

• 

  Joseph Wilk July 14th, 2008 @ 02:26 PM

  • no changes were found...

  • 0001--And-s-in-Story-HTML-output.patch 4 KB
• 

  Joseph Wilk July 14th, 2008 @ 03:55 PM

  Shiny git-format-patch now attached.

• 

  David Chelimsky July 16th, 2008 @ 06:35 AM

  • → Assigned user changed from “” to “David Chelimsky”
  • → State changed from “new” to “resolved”
  • → Milestone changed from “” to “1.1.5”

  And applied - thanks Joseph!