rspec

My autotest growl notifications stopped worked recently (independently of the growlnotify Leopard problems), and in the process of debugging this I replaced my ~/.autotest file with the following tracer code:

module Autotest::CanaryInCoalMine

  Autotest.add_hook :run_command do  |at|
    puts "============ RUNNING"
  end

  Autotest.add_hook :green do  |at|
    puts "============ GREEN"
  end

  Autotest.add_hook :all_good do  |at|
    puts "============ ALL GOOD"
  end

  Autotest.add_hook :red do  |at|
    puts "============ RED"
  end

  Autotest.add_hook :quit do  |at|
    puts "============ BYE NOW"
  end
end

I found that at no point does RSpec's autotest code ever call the :red hook.

An abbreviated example of the behavior:

$ autotest
loading autotest/rspec
============ ALL GOOD
============ RUNNING
/opt/local/bin/ruby -S /opt/local/lib/ruby/gems/1.8/gems/rspec-1.1.3/bin/spec -O spec/spec.opts  [a whole bunch of files]
...............................................................................................................................................................................................................................................................................................................................................................................................................................

Finished in 2.516881 seconds

415 examples, 0 failures
============ GOOD
============ ALL GOOD
<I manually induce a failure.>
============ RUNNING
/opt/local/bin/ruby -S /opt/local/lib/ruby/gems/1.8/gems/rspec-1.1.3/bin/spec -O spec/spec.opts  spec/happy_class_spec.rb
........F........

1)
'HappyClass should be awesome' FAILED
expected: 2,
     got: 1 (using ==)
Diff:
@@ -1,2 +1,2 @@
-1
+2

./spec/happy_class_spec.rb:94:

Finished in 0.078181 seconds

17 examples, 1 failure
============ GOOD
============ ALL GOOD
============ ALL GOOD
^CInterrupt a second time to quit
^C============ BYE NOW

This appears to be a bug in Autotest::Rspec#consolidate_failures, which does not actually parse out the failed specs and their containing files.

Replacing consolidate_failures with the following code fixes this:

  def consolidate_failures(failed)
    filters = Hash.new { |h,k| h[k] = [] }
    failed.each do |spec, trace|
      if trace =~ /\n(.*):[\d]+:\Z/
        filters[$1] << spec
      end
    end
    return filters
  end

I'm using RSpec 1.1.3 and ZenTest 3.9.1.