7315 0 true 2008-02-06T02:21:50+01:00 192 275 mock_model-is-unusable-when-using-mocha 6443 5645 invalid 2008-08-29T15:15:13+02:00 20392 gravelpup Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 I have configured my specs to use Mocha because, from what I've seen, Mocha is superior to mocking support in RSpec. @@@ ruby Spec::Runner.configure do |config| config.mock_with :mocha end @@@ Unfortunately, mock_model from Spec::Rails is then rendered unusable. That method uses the mock method to set stubs with second argument: @@@ ruby m = mock("#{model_class.name}_#{id}", options_and_stubs) @@@ But, in Mocha, the second argument for mock method are *expected methods*, not stubs! As the result, each call to mock_method sets 4 expectations: @@@ id, to_param, new_record?, errors @@@ Instead, mock_model should use "stub" with Mocha. I have no idea how to accomplish this without branching code internally in the mock_model method. That would possibly turn out simple, but would definitely be ugly. Maybe the mocking frameworks' adapters could be modified instead? I have configured my specs to use Mocha because, from what I've seen, Mocha is superior to mocking support in RSpec. @@@ ruby Spec::Runner.configure do |config| config.mock_with :mocha end @@@ Unfortunately, mock_model from Spec::Rails is then rendered unusable. That method uses the mock method to set stubs with second argument: @@@ ruby m = mock("#{model_class.name}_#{id}", options_and_stubs) @@@ But, in Mocha, the second argument for mock method are *expected methods*, not stubs! As the result, each call to mock_method sets 4 expectations: @@@ id, to_param, new_record?, errors @@@ Instead, mock_model should use "stub" with Mocha. I have no idea how to accomplish this without branching code internally in the mock_model method. That would possibly turn out simple, but would definitely be ugly. Maybe the mocking frameworks' adapters could be modified instead? <div><p> I have configured my specs to use Mocha because, from what I've seen, Mocha is superior to mocking support in RSpec. </p> <pre><code class="ruby">Spec::Runner.configure do |config| config.mock_with :mocha end </code></pre> <p> Unfortunately, mock_model from Spec::Rails is then rendered unusable. That method uses the mock method to set stubs with second argument: </p> <pre><code class="ruby">m = mock(&quot;#{model_class.name}_#{id}&quot;, options_and_stubs) </code></pre> <p> But, in Mocha, the second argument for mock method are *expected methods*, not stubs! As the result, each call to mock_method sets 4 expectations: </p> <pre><code class="">id, to_param, new_record?, errors </code></pre> <p> Instead, mock_model should use "stub" with Mocha. I have no idea how to accomplish this without branching code internally in the mock_model method. That would possibly turn out simple, but would definitely be ugly. Maybe the mocking frameworks' adapters could be modified instead? </p></div> 0 I have configured my specs to use Mocha because, from what I've seen, Mocha is superior to mocking support in RSpec. @@@ ruby Spec::Runner.configure do |config| config.mock_with :mocha end @@@ Unfortunately, mock_model from Spec::Rails is then rendered unusable. That method uses the mock method to set stubs with second argument: @@@ ruby m = mock("#{model_class.name}_#{id}", options_and_stubs) @@@ But, in Mocha, the second argument for mock method are *expected methods*, not stubs! As the result, each call to mock_method sets 4 expectations: @@@ id, to_param, new_record?, errors @@@ Instead, mock_model should use "stub" with Mocha. I have no idea how to accomplish this without branching code internally in the mock_model method. That would possibly turn out simple, but would definitely be ugly. Maybe the mocking frameworks' adapters could be modified instead? <div><p> I have configured my specs to use Mocha because, from what I've seen, Mocha is superior to mocking support in RSpec. </p> <pre><code class="ruby">Spec::Runner.configure do |config| config.mock_with :mocha end </code></pre> <p> Unfortunately, mock_model from Spec::Rails is then rendered unusable. That method uses the mock method to set stubs with second argument: </p> <pre><code class="ruby">m = mock(&quot;#{model_class.name}_#{id}&quot;, options_and_stubs) </code></pre> <p> But, in Mocha, the second argument for mock method are *expected methods*, not stubs! As the result, each call to mock_method sets 4 expectations: </p> <pre><code class="">id, to_param, new_record?, errors </code></pre> <p> Instead, mock_model should use "stub" with Mocha. I have no idea how to accomplish this without branching code internally in the mock_model method. That would possibly turn out simple, but would definitely be ugly. Maybe the mocking frameworks' adapters could be modified instead? </p></div> false 2008-02-06T02:21:50+01:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha 0 5645 new 2008-02-06T02:21:50+01:00 192 Mislav Mislav http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 Sorry, but I think if you're using a mock framework other than RSpec's, it is up to that framework to satisfy this problem. Flexmock, for example already has a mock_model (or similar) method. I'd raise this issue in the mocha tracker. <div><p> Sorry, but I think if you're using a mock framework other than RSpec's, it is up to that framework to satisfy this problem. Flexmock, for example already has a mock_model (or similar) method. </p><p> I'd raise this issue in the mocha tracker. </p></div> true 2008-02-06T16:09:21+01:00 192 --- :state: new :assigned_user: 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid 2008-02-06T16:09:21+01:00 7315 David Chelimsky Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 I don't see why I should file this in the Mocha tracker. It certainly is not a bug in their framework. I've filed the issue here because this is a case of APIs that don't match: mock in RSpec isn't equivalent to mock in Mocha. Isn't that the issue of the adapters in RSpec? The adapters were there to hide the frameworks' APIs under one common API. <div><p> I don't see why I should file this in the Mocha tracker. It certainly is not a bug in their framework. I've filed the issue here because this is a case of APIs that don't match: mock in RSpec isn't equivalent to mock in Mocha. </p><p> Isn't that the issue of the adapters in RSpec? The adapters were there to hide the frameworks' APIs under one common API. </p></div> true 2008-02-06T16:33:23+01:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid 2008-02-06T16:33:23+01:00 192 Mislav Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 The adapters are there to support using other frameworks, not to hide them from you. Nor are they there to enhance other frameworks. If the adapter was hiding mocha from you then it would force you to say "should_receive" instead of "expects" and delegate that call to mocha. Plus, making this a mocha feature request will benefit all users of mocha, not just those who choose rspec. <div><p> The adapters are there to support using other frameworks, not to hide them from you. Nor are they there to enhance other frameworks. </p><p> If the adapter was hiding mocha from you then it would force you to say "should_receive" instead of "expects" and delegate that call to mocha. </p><p> Plus, making this a mocha feature request will benefit all users of mocha, not just those who choose rspec. </p></div> true 2008-02-06T16:20:48+01:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid 2008-02-06T16:20:48+01:00 7315 David Chelimsky Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 I see. You are right. But if I suggest/contribute the mock_model feature to Mocha and it gets added under that name, isn't the method from Spec::Rails still going to be called when I use mock_model in my specs? <div><p> I see. You are right. But if I suggest/contribute the mock_model feature to Mocha and it gets added under that name, isn't the method from Spec::Rails still going to be called when I use mock_model in my specs? </p></div> true 2008-02-06T16:26:49+01:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid 2008-02-06T16:26:49+01:00 192 Mislav Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 Now *that's* a horse of a different color! There are a couple of other convenience methods that rely on rspec's mocks that init Spec::Mocks::Mock explicitly instead of using the mock method. In this case, we need to actually redefine the method. That could probably be handled in the mocha adapter by having it undef mock_model before mixing in the mocha methods. WDYT? <div><p> Now <strong>that's</strong> a horse of a different color! </p><p> There are a couple of other convenience methods that rely on rspec's </p><p> mocks that init Spec::Mocks::Mock explicitly instead of using the mock </p><p> method. In this case, we need to actually redefine the method. </p><p> That could probably be handled in the mocha adapter by having it undef </p><p> mock_model before mixing in the mocha methods. WDYT? </p></div> true 2008-02-06T16:40:15+01:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid 2008-02-06T16:40:15+01:00 7315 David Chelimsky Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 I'm definitely for undef, which can even be done unconditionally (regardless of the Mocha version I mean) because mock_model is unusable, anyway. <div><p> I'm definitely for undef, which can even be done unconditionally (regardless of the Mocha version I mean) because mock_model is unusable, anyway. </p></div> true 2008-02-06T17:08:51+01:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid 2008-02-06T17:08:51+01:00 192 Mislav Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 I applied the following dirty hack to my spec_helper.rb # Brings in the __mock_proxy Mocha::Mock.send(:include, Spec::Mocks::Methods) # Overwrites :mock method with :stub, so I stop # getting exceptions for to_params not being called Test::Unit::TestCase.send(:alias_method, :mock, :stub) <div><p> I applied the following dirty hack to my spec_helper.rb </p> <ol><li> Brings in the __mock_proxy </li></ol> <p> Mocha::Mock.send(:include, Spec::Mocks::Methods) </p> <ol><li> Overwrites :mock method with :stub, so I stop </li><li> getting exceptions for to_params not being called </li></ol> <p> Test::Unit::TestCase.send(:alias_method, :mock, :stub) </p></div> true 2008-06-05T20:34:47+02:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid 2008-06-05T20:34:47+02:00 8789 Jeremy Friesen Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 Your hacks are indeed dirty, especially the other one which, uh, overwrites the "mock" method everywhere. These are my hacks which are not destructive: @@@ ruby # override spec-rails stuff because of Mocha module Spec::Rails::Mocks def mock_model(model_class, options_and_stubs = {}) id = next_id options_and_stubs.reverse_merge! :id => id, :to_param => id.to_s, :new_record? => false, :errors => stub("errors", :count => 0) m = stub("#{model_class.name}_#{options_and_stubs[:id]}", options_and_stubs) m.instance_eval <<-CODE def is_a?(other) #{model_class}.ancestors.include?(other) end def kind_of?(other) #{model_class}.ancestors.include?(other) end def instance_of?(other) other == #{model_class} end def class #{model_class} end CODE yield m if block_given? m end # fixes spec_model def add_stubs(object, stubs = {}) m = String === object || Symbol === object ? mock(object.to_s) : object stubs.each { |k, v| m.stubs(k).returns(v) } m end end @@@ <div><p> Your hacks are indeed dirty, especially the other one which, uh, overwrites the "mock" method everywhere. </p><p> These are my hacks which are not destructive: </p> <pre><code class="ruby"># override spec-rails stuff because of Mocha module Spec::Rails::Mocks def mock_model(model_class, options_and_stubs = {}) id = next_id options_and_stubs.reverse_merge! :id =&gt; id, :to_param =&gt; id.to_s, :new_record? =&gt; false, :errors =&gt; stub(&quot;errors&quot;, :count =&gt; 0) m = stub(&quot;#{model_class.name}_#{options_and_stubs[:id]}&quot;, options_and_stubs) m.instance_eval &lt;&lt;-CODE def is_a?(other) #{model_class}.ancestors.include?(other) end def kind_of?(other) #{model_class}.ancestors.include?(other) end def instance_of?(other) other == #{model_class} end def class #{model_class} end CODE yield m if block_given? m end # fixes spec_model def add_stubs(object, stubs = {}) m = String === object || Symbol === object ? mock(object.to_s) : object stubs.each { |k, v| m.stubs(k).returns(v) } m end end </code></pre></div> true 2008-06-06T14:26:27+02:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid 2008-06-06T14:26:27+02:00 192 Mislav Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 Mislav - I'm thinking that RSpec's mock_model should be disabled if other frameworks are being used - then you could release your code as a plugin for all the world to use w/o monkey patching. WDYT? <div><p> Mislav - I'm thinking that RSpec's mock_model should be disabled if other frameworks are being used - then you could release your code as a plugin for all the world to use w/o monkey patching. </p><p> WDYT? </p></div> true 2008-06-06T15:28:03+02:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid 2008-06-06T15:28:03+02:00 7315 David Chelimsky Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 I agree that mock_model and stub_model should be disabled. But I also think that Mocha equivalents of these could be included with RSpec. I could contribute that. <div><p> I agree that mock_model and stub_model should be disabled. But I also think that Mocha equivalents of these could be included with RSpec. I could contribute that. </p></div> true 2008-06-06T20:25:16+02:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid 2008-06-06T20:25:16+02:00 192 Mislav Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 I'd rather you publish them separately. We've had a couple of similar contributions in the past that stopped working when the other libraries changed, increasing what is already a significant maintenance burden. Are you open to publishing/maintaining your own plugin? <div><p> I'd rather you publish them separately. We've had a couple of similar contributions in the past that stopped working when the other libraries changed, increasing what is already a significant maintenance burden. </p><p> Are you open to publishing/maintaining your own plugin? </p></div> true 2008-06-06T20:34:54+02:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid 2008-06-06T20:34:54+02:00 7315 David Chelimsky Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 Yeah, I will use it myself so no problem pushing it on GitHub. I would probably call it "rspec-mocha" (following the "rspec-rails" convention). <div><p> Yeah, I will use it myself so no problem pushing it on GitHub. I would probably call it "rspec-mocha" (following the "rspec-rails" convention). </p></div> true 2008-06-06T20:47:23+02:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid 2008-06-06T20:47:23+02:00 192 Mislav Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 @Mislav: any progress on that plugin? I'd be interested in grabbing it when it's up on GitHub. <div><p>@Mislav: any progress on that plugin? I'd be interested in grabbing it when it's up on GitHub.</p></div> true 2008-08-28T23:40:30+02:00 192 --- :tag: 275 mock_model-is-unusable-when-using-mocha 0 5645 invalid mocha mocks mock_model rspec_on_rails stubs 2008-08-28T23:40:30+02:00 20392 gravelpup Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 Sorry I forgot about this; now it's imported http://github.com/mislav/rspec-rails-mocha/tree/master <div><p>Sorry I forgot about this; now it's imported <a href="http://github.com/mislav/rspec-rails-mocha/tree/master">http://github.com/mislav/rspec-r...</a></p></div> true 2008-08-29T03:50:33+02:00 192 --- :tag: mocha mocks mock_model rspec_on_rails stubs 275 mock_model-is-unusable-when-using-mocha-2 0 5645 invalid 2008-08-29T03:50:33+02:00 192 Mislav Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275 7315 0 Awesome. Thanks! <div><p>Awesome. Thanks!</p></div> true 2008-08-29T15:15:13+02:00 192 --- {} 275 mock_model-is-unusable-when-using-mocha-3 0 5645 invalid 2008-08-29T15:15:13+02:00 20392 gravelpup Mislav David Chelimsky http://rspec.lighthouseapp.com/projects/5645/tickets/275